fix: add TypeScript types and tighten types in NotificationCenter (#306) - #2
Merged
Merged
Conversation
…ttaChain#306) - Add React.FC<NotificationCenterProps> type annotation to component - Extract getAlertIcon and getAlertMessage as module-level functions with explicit return types - Add useCallback wrappers for event handlers with explicit void return types - Add explicit type annotations: useState<boolean>, unreadCount: number - Add type-only imports for ReactNode - Remove redundant type annotation in alert.filter callback - Simplify control flow by removing else after returns - Add comprehensive unit tests (17 tests) covering all states
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nTighten TypeScript types in NotificationCenter component to reduce implicit any usage and catch errors at compile-time.\n\n## Changes\n- Added
React.FC<NotificationCenterProps>type annotation to component\n- Extracted helper functions outside component with explicit return types (ReactNode,string)\n- AddeduseCallbackwrappers for event handlers with explicitvoidreturn types\n- Added explicit type annotations (useState<boolean>,unreadCount: number)\n- Removed redundant type annotations and simplified control flow\n- Added 17 unit tests covering all component states\n\nCloses MettaChain#306